-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] cleaned up formatting in R C/C++ files #2844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Feb 29, 2020
jameslamb
force-pushed
the
misc/r-api-formatting
branch
from
March 4, 2020 17:15
1912f53
to
074eae6
Compare
StrikerRUS
reviewed
Mar 4, 2020
StrikerRUS
approved these changes
Mar 4, 2020
Laurae2
previously requested changes
Mar 7, 2020
jameslamb
force-pushed
the
misc/r-api-formatting
branch
from
March 10, 2020 01:53
5891bbf
to
f2c0f8f
Compare
Thanks for the reviews! |
jameslamb
dismissed
Laurae2’s stale review
March 10, 2020 04:42
Made the requested minor change in f2c0f8f
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a style-only PR. As I've been working on #629 , I see a few opportunities to make the current R-specific parts of
lib_lightgbm
a bit easier to read and edit. The diff looks a bit weird here on GitHub, but to be clear I did not change any of what the code in these files does. In this PR, I'm just proposing some indentation changes, for example taking definitions like this:and turning them into this
I also changed the language in the comment at the top of
R_object_helper.h
to better reflect the current state of the R package.