-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more bots #2843
add more bots #2843
Conversation
ping @StrikerRUS and @jameslamb . |
To be honest, I find that bots make process messy. For example, lockbot: I don't want to wake up, open my email app and see 30+ email from bots. I don't want to unsubscribe from all notifications from closed issues because I want to get notifications for user's comments, but I cannot customize to not get notifications about bot's comments. Also, this bot breaks the order of closed issues when you apply |
@StrikerRUS WIP is a light bot, I think have it or no have it have no differences. Reminder is a user-activated function, I think it is safe to add. |
BTW, we can disable the comments from bots, let it just lock/close the thread. |
@guolinke Yep, making bots less verbose is very cool thing! Please give me some time to read about new bots. |
.github/no-response.yml
Outdated
# Label requiring a response | ||
responseRequiredLabel: awaiting response | ||
# Comment to post when closing an Issue for lack of response. Set to `false` to disable | ||
closeComment: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please add a closeComment
? We don't want an impersonal to response to discourage people from coming back to ask questions. My proposal:
closeComment: >
This issue has been automatically closed because it has been awaiting a response for too long.
When you have time to to work with the maintainers to resolve this issue, please post a new comment and it will be re-opened.
If the issue has been locked for editing by the time you return to it, please open a new issue and reference this one. Thank you for taking the time to improve LightGBM!
In my opinion we should not use the I think we need to develop the discipline ourselves of preferring GitHub issues to TODO/FIXME comments in code. One way to nudge people on this is to use linters to prevent TODO/FIXME comments from being merged, like I've done in the R package I read the docs for TODO bot and I feel it's not worth the overhead. To make it usable you have to learn their specific comment syntax, and I'm pretty confident that what you can express in those contents will only be a subet of features you get with directly authoring issues (e.g. attaching screenshots). |
@StrikerRUS @jameslamb
Maybe some of PR is categorized into wrong classes, you can double-check it. |
@guolinke I've labeled the rest of PRs and replaced some labels. You can check them by sorting closed PRs by "Recently updated" (~3 pages). |
thanks @StrikerRUS . |
- title: 📖 Documentation | ||
label: doc | ||
- title: 🧰 Maintenance | ||
label: maintenance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@StrikerRUS @jameslamb any better emojis for these items?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guolinke I think these ones are quite good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, these are good
.github/no-response.yml
Outdated
# Configuration for probot-no-response - https://github.com/probot/no-response | ||
|
||
# Number of days of inactivity before an Issue is closed for lack of response | ||
daysUntilClose: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guolinke
Sorry, haven't had a chance to read about bots yet. But at present I'm personally trying to give from 25 to 30 days for providing any feedback after the last ping. Maybe we can increase this value for at least 21 days?..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I agree with this. I think 21 or even 30 days would be better. I think the main goal of the bot should be to automate some of the work we do to clean up things that are months old
Seems that lockbot is still not working... |
Will Release Drafter conflict with our current release changelog maker? Line 191 in 676b288
|
@StrikerRUS yeah, I think we can disable the changlog generated by vsts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with these changes, as long as we resolve https://github.com/microsoft/LightGBM/pull/2843/files#r386695405
@StrikerRUS @jameslamb any other suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me @guolinke , thanks!
Release Drafter: https://probot.github.io/apps/release-drafter/
Work In Progress: https://probot.github.io/apps/wip/
Reminders: https://probot.github.io/apps/reminders/
No Response: https://probot.github.io/apps/no-response/