Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more bots #2843

Merged
merged 7 commits into from
Mar 7, 2020
Merged

add more bots #2843

merged 7 commits into from
Mar 7, 2020

Conversation

guolinke
Copy link
Collaborator

@guolinke guolinke commented Feb 29, 2020

@guolinke
Copy link
Collaborator Author

ping @StrikerRUS and @jameslamb .
I like Release Drafter most. However, to better use it, we should label all PRs for Now.

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Feb 29, 2020

To be honest, I find that bots make process messy.

For example, lockbot: I don't want to wake up, open my email app and see 30+ email from bots. I don't want to unsubscribe from all notifications from closed issues because I want to get notifications for user's comments, but I cannot customize to not get notifications about bot's comments. Also, this bot breaks the order of closed issues when you apply Recently updated sort order: really updated issues are lost in the dozens of "recently locked" issues.

@guolinke
Copy link
Collaborator Author

@StrikerRUS
Yeah, the lock bot is a little bit annoying, we can set skipCreatedBefore to avoid it locks these old issues.
For the rest bots, I think only No Response will comment and close the issues, but it should only comment on the non-closed issues.

WIP is a light bot, I think have it or no have it have no differences.
todo is mainly for myself, sometimes I will forget to create new issues for these todos.

Reminder is a user-activated function, I think it is safe to add.

@guolinke
Copy link
Collaborator Author

guolinke commented Feb 29, 2020

BTW, we can disable the comments from bots, let it just lock/close the thread.

@StrikerRUS
Copy link
Collaborator

@guolinke Yep, making bots less verbose is very cool thing!

Please give me some time to read about new bots.

# Label requiring a response
responseRequiredLabel: awaiting response
# Comment to post when closing an Issue for lack of response. Set to `false` to disable
closeComment: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we please add a closeComment? We don't want an impersonal to response to discourage people from coming back to ask questions. My proposal:

closeComment: >
    This issue has been automatically closed because it has been awaiting a response for too long.
    When you have time to to work with the maintainers to resolve this issue, please post a new comment and it will be re-opened.
    If the issue has been locked for editing by the time you return to it, please open a new issue and reference this one. Thank you for taking the time to improve LightGBM!

@jameslamb
Copy link
Collaborator

Release Drafter: https://probot.github.io/apps/release-drafter/
Work In Progress: https://probot.github.io/apps/wip/
todo: https://probot.github.io/apps/todo/
Reminders: https://probot.github.io/apps/reminders/
No Response: https://probot.github.io/apps/no-response/

In my opinion we should not use the todo bot.

I think we need to develop the discipline ourselves of preferring GitHub issues to TODO/FIXME comments in code. One way to nudge people on this is to use linters to prevent TODO/FIXME comments from being merged, like I've done in the R package

I read the docs for TODO bot and I feel it's not worth the overhead. To make it usable you have to learn their specific comment syntax, and I'm pretty confident that what you can express in those contents will only be a subet of features you get with directly authoring issues (e.g. attaching screenshots).

@guolinke
Copy link
Collaborator Author

guolinke commented Mar 1, 2020

@StrikerRUS @jameslamb
I almost labeled all PRs since the last release.
I categorize PRs into the following classes:

  • feature, PR with the new functions
  • breaking, change of existing functions, result in different results, break the compatibility.
  • doc, documentation related
  • fix, bug fixes
  • maintenance, related CI, tests, code style, or other changes that don't need to expose to users.
  • efficiency, related to efficiency improvement

Maybe some of PR is categorized into wrong classes, you can double-check it.

@StrikerRUS
Copy link
Collaborator

@guolinke I've labeled the rest of PRs and replaced some labels. You can check them by sorting closed PRs by "Recently updated" (~3 pages).

@guolinke
Copy link
Collaborator Author

guolinke commented Mar 2, 2020

thanks @StrikerRUS .
@jameslamb I agree to remove todo bot, it seems messy in this PR: #2850

.github/no-response.yml Outdated Show resolved Hide resolved
- title: 📖 Documentation
label: doc
- title: 🧰 Maintenance
label: maintenance
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@StrikerRUS @jameslamb any better emojis for these items?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolinke I think these ones are quite good! 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these are good

# Configuration for probot-no-response - https://github.com/probot/no-response

# Number of days of inactivity before an Issue is closed for lack of response
daysUntilClose: 14
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guolinke
Sorry, haven't had a chance to read about bots yet. But at present I'm personally trying to give from 25 to 30 days for providing any feedback after the last ping. Maybe we can increase this value for at least 21 days?..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ I agree with this. I think 21 or even 30 days would be better. I think the main goal of the bot should be to automate some of the work we do to clean up things that are months old

@StrikerRUS
Copy link
Collaborator

Seems that lockbot is still not working...

@StrikerRUS
Copy link
Collaborator

Will Release Drafter conflict with our current release changelog maker?

addChangeLog: true

@guolinke
Copy link
Collaborator Author

guolinke commented Mar 4, 2020

@StrikerRUS yeah, I think we can disable the changlog generated by vsts.

@jameslamb jameslamb self-requested a review March 4, 2020 16:30
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with these changes, as long as we resolve https://github.com/microsoft/LightGBM/pull/2843/files#r386695405

.github/no-response.yml Outdated Show resolved Hide resolved
@guolinke
Copy link
Collaborator Author

guolinke commented Mar 6, 2020

@StrikerRUS @jameslamb any other suggestions?

@jameslamb jameslamb self-requested a review March 6, 2020 15:54
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @guolinke , thanks!

@guolinke guolinke changed the title [WIP] add more bots add more bots Mar 7, 2020
@guolinke guolinke merged commit 018bdd3 into master Mar 7, 2020
@guolinke guolinke deleted the more-bots branch March 7, 2020 15:58
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants