avoid most_freq_bin to be 0 in categorical features #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
commented
Feb 26, 2020
guolinke
requested review from
jameslamb,
Laurae2 and
StrikerRUS
as code owners
guolinke
commented
Feb 26, 2020
StrikerRUS
reviewed
Feb 26, 2020
src/io/bin.cpp
Outdated
| static_cast<double>(cnt_in_bin[most_freq_bin_]) / total_sample_cnt; | ||
| // When most_freq_bin_ != default_bin_, there are some additional data loading costs. | ||
| // so use most_freq_bin_ = default_bin_ when there is not so sparse | ||
| if (most_freq_bin_ != default_bin_ && max_sparse_rate <= 0.7f) { |
There was a problem hiding this comment.
kSparseThreshold?
LightGBM/include/LightGBM/bin.h
Line 36 in e676af2
guolinke
commented
Feb 27, 2020
StrikerRUS
reviewed
Feb 27, 2020
| CHECK(default_bin_ > 0); | ||
| if (most_freq_bin_ == 0) { | ||
| CHECK(num_bin_ > 1); | ||
| // FIXME: how to enable `most_freq_bin_ = 0` for categorical features |
There was a problem hiding this comment.
@guolinke Create issue for FIXME to not lose it?
There was a problem hiding this comment.
^ I agree, we should be using issues instead of TODO, FIXME, etc.
There was a problem hiding this comment.
I think this a not trivial, so a fixme is here.
BTW, PR #2463 will rewrite categorical feature solutions, and these codes are not needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix #2742