[R-package] added test that Dataset$setinfo() converts 'group' input to integer #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
force-pushed
the
tests/setinfo
branch
from
a0ea587 to
dee3cf5
Compare
jameslamb
force-pushed
the
tests/setinfo
branch
from
dee3cf5 to
6d70822
Compare
|
rebased to |
guolinke
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current,
Dataset$setinfo()has the behavior "if you pass in something for 'group', convert it to integer before storing it". That behavior is not currently tested. This PR adds a test for it.