[R-package] clarified error messages and documentation for lgb.get.eval.result() #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
reviewed
Jan 13, 2020
jameslamb
force-pushed
the
tests/get_eval
branch
from
23e82ff to
c77ac90
Compare
|
Seems that the latest force-push reverted all fixes applied after review. |
ah sorry! Will fix right now |
jameslamb
force-pushed
the
tests/get_eval
branch
from
296c028 to
0e0b1cd
Compare
ok @StrikerRUS I've added the changes back in 0e0b1cd and rebased to current |
|
@jameslamb Thanks! |
guolinke
approved these changes
Jan 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I propose some more user-friendly documentation and error messages for
lgb.get.eval_result(). I think it would be helpful to be more explicit about how someone can find valid values ofdata_nameandeval_name.I've also added tests on the validations in this function, since currently they are not covered by tests.