-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] Added instructions for generating R test coverage #2664
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
822cd15
to
b38cd65
Compare
Just rebased to current @StrikerRUS normally I wouldn't merge an |
Sure! |
b38cd65
to
a06fdbc
Compare
Really excited to say that I've discovered that
covr
(the most popular library for generating test coverage for R projects) now works well withlightgbm
's R package! I had created jameslamb/lightgbm-r-coverage to work around the previous issues I had and I am VERY excited to archive that repo.In this PR, I propose adding instructions to the R package's README explaining how contributors can generate coverage reports. I think this will be a valuable way for us to catch edge cases that are not covered by our current tests, and all the other good things you can do with code coverage.
At the time of creating this PR, the R package is
64.48%
covered.I've attached a detailed coverage report for those who are curious (GitHub will not let you attach a
.html
file, so had to zip it).coverage.html.zip