Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R-package] Add unit tests for best metric iteration/value #2525

Closed
Laurae2 opened this issue Oct 23, 2019 · 3 comments
Closed

[R-package] Add unit tests for best metric iteration/value #2525

Laurae2 opened this issue Oct 23, 2019 · 3 comments
Labels
feature request help wanted r-package

Comments

@Laurae2
Copy link
Contributor

Laurae2 commented Oct 23, 2019

After PR #2471 gets merged, unit tests should be added to ensure correctness of the iteration and value of the best metric during training of a LightGBM model.

A test matrix could be the following:

  • Train + 1 metric
  • Train + n metric
  • n test + 1 metric
  • n test + n metric
  • Train + n test + 1 metric
  • Train + n test + n metric
@guolinke guolinke mentioned this issue Oct 23, 2019
Open
@StrikerRUS
Copy link
Collaborator

@Laurae2 Are you going to work on this issue? If not, we should add help wanted label and close it according to the feature requests policy.

@StrikerRUS
Copy link
Collaborator

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@jameslamb jameslamb mentioned this issue Mar 31, 2020
Merged
jameslamb added a commit that referenced this issue Apr 25, 2020
@jameslamb
[R-package] fixed best_iter and best_score when training data is pass…
1f3e72c 
…ed (fixes #2295, #2525) (#2961)

* [R-package] fixed best_iter and best_score when early_stopping is not used (fixes #2295)

* fixed tests
@jameslamb
Copy link
Collaborator

This has been solved by #2961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request help wanted r-package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jameslamb @Laurae2 @StrikerRUS