Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce gsl::swap for swapping gsl::not_null #1160

Merged
merged 2 commits into from
Dec 13, 2024
Merged

introduce gsl::swap for swapping gsl::not_null #1160

merged 2 commits into from
Dec 13, 2024

Conversation

carsonRadtke
Copy link
Collaborator

fixes: #1129

  • create gsl::swap(T&, T&) which wraps std::swap
  • specialize gsl::swap(gsl::not_null&, gsl::not_null&)
  • add tests

@carsonRadtke
introduce gsl::swap for swapping gsl::not_null
d988e0e 
fixes: microsoft#1129

* create gsl::swap<T>(T&, T&) which wraps std::swap
* specialize gsl::swap<T>(gsl::not_null<T>&, gsl::not_null<T>&)
* add tests
@carsonRadtke carsonRadtke added Priority: Low Can be handled at leisure Type: Enhancement Suggests an improvement or new feature Status: Blocked Cannot proceed due to external factors labels Dec 2, 2024
@carsonRadtke carsonRadtke mentioned this pull request Dec 13, 2024
Merged
@carsonRadtke carsonRadtke self-assigned this Dec 13, 2024
@carsonRadtke carsonRadtke added Status: In Progress Currently being worked on and removed Status: Blocked Cannot proceed due to external factors labels Dec 13, 2024
@carsonRadtke carsonRadtke merged commit 2724630 into microsoft:main Dec 13, 2024
83 checks passed
@carsonRadtke carsonRadtke deleted the gh-1129 branch December 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@carsonRadtke carsonRadtke

Labels
Priority: Low Can be handled at leisure Status: In Progress Currently being worked on Type: Enhancement Suggests an improvement or new feature
Projects
Microsoft/GSL Pull Requests In-Flight
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing swap for gsl::not_null for move-only types
1 participant
@carsonRadtke