Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct comment about ISummaryAuthor and ISummaryCommitter in breaking.md #10981

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Correct comment about ISummaryAuthor and ISummaryCommitter in breaking.md #10981

merged 1 commit into from
Jul 6, 2022

Conversation

ghoshkaj
Copy link
Contributor

@ghoshkaj ghoshkaj commented Jul 6, 2022

In #10933 I merged in an incorrect comment about deprecating the ISummaryAuthor and ISummaryCommitter interfaces instead of removing them. This PR corrects that error. See https://github.com/microsoft/FluidFramework/pull/10933/files#r915129886 for context.

The ticket is here: #10456

@ghoshkaj ghoshkaj requested review from msfluid-bot and a team as code owners July 6, 2022 19:04
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file labels Jul 6, 2022
@github-actions github-actions bot added the public api change Changes to a public API label Jul 6, 2022
@ghoshkaj ghoshkaj mentioned this pull request Jul 6, 2022
Merged
@github-actions github-actions bot added the base: main PRs targeted against main branch label Jul 6, 2022
@ghoshkaj ghoshkaj changed the base branch from main to next July 6, 2022 19:05
@ghoshkaj ghoshkaj self-assigned this Jul 6, 2022
@ghoshkaj ghoshkaj requested a review from alexvy86 July 6, 2022 19:05
@sonalivdeshpande sonalivdeshpande merged commit f8bd157 into microsoft:next Jul 6, 2022
@ghoshkaj ghoshkaj deleted the correct-comment-about-ISummaryAuthor-and-ISummaryCommitter-in-breaking branch July 6, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvy86 alexvy86 alexvy86 approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees

@ghoshkaj ghoshkaj

@sonalivdeshpande sonalivdeshpande

Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch breaking change This PR or issue would introduce a breaking change dependencies Pull requests that update a dependency file public api change Changes to a public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghoshkaj @alexvy86 @sonalivdeshpande