fix user args parsing of string with spaces on runner #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
reviewed
Sep 5, 2023
mrwyattii
approved these changes
Sep 11, 2023
loadams
approved these changes
Sep 11, 2023
CurryRice233
pushed a commit
to CurryRice233/DeepSpeed
that referenced
this pull request
Sep 15, 2023
* origin/master: (48 commits) Fix autotune to support Triton 2.1 (microsoft#4340) Fix skipped inference tests (microsoft#4336) Suppress noise (microsoft#4310) Fix a bug in the implementation of dequantization for inference (microsoft#3433) DS-Chat BLOOM: Fix Attention mask (microsoft#4338) clear redundant timers (microsoft#4308) Add release version checking (microsoft#4328) Fix Zero3 contiguous grads, reduce scatter false accuracy issue (microsoft#4321) Clean up modeling code (microsoft#4320) Handle empty parameter groups (microsoft#4277) Update README.md (microsoft#4316) README update (microsoft#4303) Update release and bump patch versioning flow (microsoft#4286) added a bert-model check for triton (microsoft#4266) ZeRO-Inference v2 release bump to 0.10.4 Update index.md (microsoft#4297) fix user args parsing of string with spaces on runner (microsoft#4265) ZeRO-Inference refresh (microsoft#4197) AMD Kernel Compatibility Fixes (microsoft#3180) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating my DeepSpeed version and rerunning my program, I noticed that string arguments with spaces in user_args are not being parsed correctly as before. For example:
deepspeed --include=localhost:0,1 --master_port=12345 generate.py --arg1 "Hello world!"It will cause error that
error: unrecognized arguments: world!, i think it is caused by #4007. It concates all the user args then split to solve the bug. I have fixed the above issue by implementing a conditional check.