Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bing/optimizer naming #3354

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Bing/optimizer naming #3354

wants to merge 23 commits into from

Conversation

xiexbing
Copy link
Contributor

@xiexbing xiexbing commented Apr 23, 2023 •
edited by tjruwase
Loading

add the optimizer information about the providers, the variants, the status of fuse.

Fixes #3050

@xiexbing xiexbing linked an issue Apr 23, 2023 that may be closed by this pull request
[BUG] Explicit Optimizer naming in logs #3050
Closed
jeffra
jeffra approved these changes Apr 23, 2023
View reviewed changes
Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xiexbing this is awesome :)

tjruwase
tjruwase requested changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@tjruwase tjruwase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some unit tests for this? I am happy to chat about them.

@conglongli conglongli added deepspeed-chat Related to DeepSpeed-Chat and removed deepspeed-chat Related to DeepSpeed-Chat labels Apr 30, 2023
@xiexbing xiexbing requested a review from tjruwase May 12, 2023 21:24
@xiexbing xiexbing requested a review from mrwyattii as a code owner May 13, 2023 04:31
@xiexbing
Copy link
Contributor Author

Can you please add some unit tests for this? I am happy to chat about them.

changed printout format and add a unit test

@jomayeri jomayeri self-assigned this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@jeffra jeffra jeffra approved these changes

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

Assignees

@jomayeri jomayeri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Explicit Optimizer naming in logs
6 participants
@xiexbing @jeffra @tjruwase @conglongli @jomayeri @loadams