-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard shortcuts #553
Conversation
Preview build will be at |
Also focuses on action's record button
Additionally, focus on action name input when there is no record button to focus on when switching row focus via up/down keys.
7d1d1fb
to
7ab49ff
Compare
So that the delay does not apply when updating the name from length 0 to something
There is ambiguity as to which keys to use and there needs to be a way of disabling certain keys when dialogs are open
- Centralise whether dialog is opened in store - Refactor suppressing of overlapping dialogs
The reset settings confirmation dialog is opened within settings dialog, so the settings dialog state is sufficient.
and use connection stage hook instead
My thoughts for discussion with the web team:
|
I think the suggestions from @microbit-robert all seems reasonable, @microbit-matt-hillsdon what are you thoughts on them? Thanks! |
Not so sure about switching to a toggle approach - kinda nice not to have to know the current state to try an action. Might be helpful for screenreader users. No strong view on "Edit in MakeCode". The rest of Rob's suggestions make sense to me. |
This PR addresses this issue: Add keyboard shortcuts
Related closed issue: Regions + shortcuts
Below's list is adapted from related issues. Bullet point items have not been implemented.
Data page
(i.e. before training a model)
Shortcuts:
Model testing page
(i.e. after training)
Shortcuts