Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added continuous fragment mode #89

Merged
merged 5 commits into from
Feb 8, 2021
Merged

Added continuous fragment mode #89

merged 5 commits into from
Feb 8, 2021

Conversation

pablogs9
Copy link
Member

@pablogs9 pablogs9 commented Dec 9, 2020 •
edited
Loading

Before merge:

@pablogs9 pablogs9 requested a review from jamoralp December 9, 2020 09:43
jamoralp
jamoralp previously approved these changes Dec 10, 2020
View reviewed changes
@pablogs9 pablogs9 marked this pull request as draft December 17, 2020 08:23
@pablogs9 pablogs9 mentioned this pull request Jan 26, 2021
Merged
43 tasks
@pablogs9 pablogs9 force-pushed the feature/continous_fragment branch from 874b5be to 3516a99 Compare January 27, 2021 08:47
@pablogs9 pablogs9 changed the base branch from foxy to main January 27, 2021 09:19
@pablogs9
Copy link
Member Author

pablogs9 commented Feb 3, 2021 •
edited
Loading

This PR should target foxy -> DONE

@pablogs9 pablogs9 force-pushed the feature/continous_fragment branch from 3516a99 to c657157 Compare February 3, 2021 13:58
@pablogs9 pablogs9 changed the base branch from main to foxy February 3, 2021 14:14
@pablogs9 pablogs9 force-pushed the feature/continous_fragment branch from e0800e5 to 187094a Compare February 4, 2021 10:18
@pablogs9
Copy link
Member Author

pablogs9 commented Feb 8, 2021

I have linked callback with a certain publisher in order to manage it independently for each entity

@pablogs9 pablogs9 requested a review from jamoralp February 8, 2021 09:18
@pablogs9 pablogs9 marked this pull request as ready for review February 8, 2021 09:19
@pablogs9 pablogs9 merged commit f48d6a0 into foxy Feb 8, 2021
@pablogs9 pablogs9 deleted the feature/continous_fragment branch February 8, 2021 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamoralp jamoralp jamoralp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablogs9 @jamoralp