Fix broken pvPortReallocMicroROS() implementation #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original `pvPortReallocMicroROS()` implementation copies more bytes than expected, which causes memory error when using functions like `rosidl_runtime_c__String__assignn()`.
pablogs9
approved these changes
Mar 9, 2022
|
@mergify backport main foxy |
🟠 Waiting for conditions to match
Hey, I reacted but my real name is @Mergifyio |
pablogs9
requested changes
Mar 9, 2022
pablogs9
approved these changes
Mar 9, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
The original `pvPortReallocMicroROS()` implementation copies more bytes than expected, which causes memory error when using functions like `rosidl_runtime_c__String__assignn()`. (cherry picked from commit 5b627a1)
mergify bot
pushed a commit
that referenced
this pull request
Mar 9, 2022
The original `pvPortReallocMicroROS()` implementation copies more bytes than expected, which causes memory error when using functions like `rosidl_runtime_c__String__assignn()`. (cherry picked from commit 5b627a1)
✅ Backports have been created
|
pablogs9
pushed a commit
that referenced
this pull request
Mar 9, 2022
The original `pvPortReallocMicroROS()` implementation copies more bytes than expected, which causes memory error when using functions like `rosidl_runtime_c__String__assignn()`. (cherry picked from commit 5b627a1) Co-authored-by: Haowei Wen <[email protected]>
pablogs9
pushed a commit
that referenced
this pull request
Mar 9, 2022
The original `pvPortReallocMicroROS()` implementation copies more bytes than expected, which causes memory error when using functions like `rosidl_runtime_c__String__assignn()`. (cherry picked from commit 5b627a1) Co-authored-by: Haowei Wen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
pvPortReallocMicroROS()implementation copies more bytes than expected, which causes memory error when using functions likerosidl_runtime_c__String__assignn().