wgrep-helm.el: Add missing Package-Requires for helm #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package requires helm, because it uses helm-grep-split-line from helm-grep.el. See wgrep-helm.el:L47. helm-grep.el first appeared in Helm 1.4.0, so I've set that as the required version.
sten0
force-pushed
the
add-missing-package-requires
branch
from
7a72970 to
fcd8c22
Compare
|
Edit was due to an error in my commit message. Fixed! |
|
Your patch does not cause problem right away although, I don't want cyclic reference for helm to avoid loading problem. helm is a Master, wgrep-helm is a Slave (means optional package for helm user). This |
|
Thank you for the tip. Hm, yes, this sounds tricky... Please keep this PR open while I consult the rest of the Debian Emacsen Team, because I don't use Helm, and I'm not yet sure what the correct resolution is. 'hoping to provide a follow-up soon, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package requires helm, because it uses helm-grep-split-line from
helm-grep.el. See wgrep-helm.el:L47.
helm-grep.el first appeared in Helm 1.4.0, so I've set that as the required version.