Replace atomic-shim::AtomicU64 with crossbeam-utils::atomic::AtomicCell<u64>
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stupid benchmark tests are broken, but, this looks good to me. A lot less conditional code, too. |
tobz
approved these changes
Aug 4, 2021
|
Thanks for your contribution! |
|
Could you make a new release for this? @tobz |
|
@paolobarbolini Yep, good call. Released |
|
Thanks @tobz |
|
Unfortunately I think this breaks MIPS build? #54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicCellseems to be a better option to me, as it supports many more targets (for example this is the list of targets with no atomic support that work with crossbeam), is maintained andatomic-shimrelies upon anyway