Simplify content-dependent schema creation #866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
m/-simple-schema
andm/-collection-schema
support "content-dependent schema creation", which mean you can use schemaproperties
andchildren
to create the actualSchema
instance. Old mechanism to do this was using a arity2 callback functionchildren properties -> props
instead of actual property map. This is a bad because:IntoSchema
instance. e.g.?props
options
was not passed on to the callbackThis MR introduces a
:compile
options, which is a arity3 functionchildren properties options -> props
. Original properties (without the:compile
) are merged to the result of the:compile
function, so one can define static properties ahead of time an this works now:It's a breaking change for the extender API, marked as
m/-deprecated
so it's easy to migrate to using this.Bump into this while working on #264.
Usage example: