Add clj-kondo support for cljs function schemas #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thheller
suggested changes
Feb 1, 2023
dvingo
force-pushed
the
write-cljs-kondo-config3
branch
from
e392d0c to
cca04b4
Compare
|
Thanks @thheller ! updated per your feedback : ) |
dvingo
force-pushed
the
write-cljs-kondo-config3
branch
from
cca04b4 to
6f5c509
Compare
thheller
approved these changes
Feb 1, 2023
dvingo
force-pushed
the
write-cljs-kondo-config3
branch
from
6f5c509 to
1c2a1ec
Compare
ah of course - updated |
dvingo
force-pushed
the
write-cljs-kondo-config3
branch
from
1c2a1ec to
7f681d8
Compare
|
This is really well though though, implemented and documented 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828
After lots of help from Thomas Heller here I was able to put together a much simpler dev experience for cljs.
This PR adds kondo config and updates the docs with Thomas' recommended setup using a preload and namespace ordering by the compiler to ensure your function schemas are up to date when
malli.dev.cljs/start!is evaluated at compile-time.I updated the kondo
save!function to emit to a different location for clj and cljs schemas so you can seamlessly use both during development. Let me know if you have any concerns or feedback about that .