Optional argument default-fn to mt/default-value-transformer
#582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't expect the tests to fail when adding one optional argument atop upstream commit – but I guess it's what tests are for 😛 If there were any interest in this, happy to make tests pass, work out some real-life examples, and add it to the README. |
See an example usage here: https://github.com/piotr-yuxuan/malli-cli/blob/main/src/piotr_yuxuan/malli_cli.clj#L220-L222 This doesn't change existing behaviour but only add `default-fn` optional argument. When set, this function is applied on the default value found under key `key`. This optional, additional indirection allows a seamless way to define `:env-var` defaults.
|
Just amended the commit, which makes the update quite straightforward I guess. |
|
Looks good, could you add a test for this to avoid future regression. |
Test additional argument to default-value-transformer. It emphasizes that the function depends on the transformer, not the schema.
|
changed this to 2-arity, passing in the schema too as first argument: (m/decode
[:map
[:os [:string {:property "os.name"}]]
[:timezone [:string {:property "user.timezone"}]]]
{}
(mt/default-value-transformer
{:key :property
:default-fn (fn [_ x] (System/getProperty x))}))
; => {:os "Mac OS X", :timezone "Europe/Helsinki"} |
|
Sorry for the broken tests, I should have been more engaged and proactively merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See an example usage here: https://github.com/piotr-yuxuan/malli-cli/blob/main/src/piotr_yuxuan/malli_cli.clj#L220-L222
This doesn't change existing behaviour but only add
default-fnoptional argument. When set, this function is applied on the default value found under keykey. In the example above this optional, additional indirection allows a seamless way to define:env-vardefaults.