Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clj-kondo dir configurable #1062

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

simonacca
Copy link
Contributor

Hello,
in a monorepo setting I had the need to configure the malli-kondo integration to accommodate the clj-kondo dir being in a non-standard location.

This can of course already be achieved by overwriting a few functions from malli.clj-kondo and malli.dev.
The following changes would make this kind of setup supported out of the box.

I'd also support merging only the first commit in case you don't want to merge the instrument! options and the emit! ones.

p.s. this is the monorepo structure in question:

├── apps
│   ├── app1    <- clj/cljs interpreter is started here
│   └── app2
└── clj_src
    ├── .clj-kondo
    └── my-corp     <- all code lives here

@simonacca simonacca force-pushed the configurable-clj-kondo-dir branch from d6981f0 to 6380576 Compare May 29, 2024 14:22
@simonacca simonacca force-pushed the configurable-clj-kondo-dir branch from 6380576 to bb4fb43 Compare May 29, 2024 14:33
@ikitommi ikitommi merged commit 64e91d1 into metosin:master Jun 4, 2024
9 checks passed
@ikitommi
Copy link
Member

ikitommi commented Jun 4, 2024

makes sense, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants