Merge pull request #1142 from frenchy64/float-explainer

add :float humanizer
metosin · Dec 8, 2024 · 0b69456 · 0b69456
2 parents 13984e4 + f3816b9
commit 0b69456
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 22 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -22,6 +22,7 @@ Malli is in well matured [alpha](README.md#alpha).
   * use `:gen/return nil` property to restore this behavior
 * Support decoding map keys into keywords for `[:map` schemas in `json-transformer` [#1135](https://github.com/metosin/malli/issues/1135)
 * FIX: `malli.registry/{mode,type}` not respected in Babashka [#1124](https://github.com/metosin/malli/issues/1124)
+* FIX: `:float` missing humanizer [#1122](https://github.com/metosin/malli/issues/1122)
 * Updated dependencies:
 
 ```

diff --git a/src/malli/error.cljc b/src/malli/error.cljc
@@ -135,6 +135,7 @@
                                  negated "should be a string")))}}
    :int {:error/fn {:en (-pred-min-max-error-fn {:pred int?, :message "should be an integer"})}}
    :double {:error/fn {:en (-pred-min-max-error-fn {:pred double?, :message "should be a double"})}}
+   :float {:error/fn {:en (-pred-min-max-error-fn {:pred float?, :message "should be a float"})}}
    :boolean {:error/message {:en "should be a boolean"}}
    :keyword {:error/message {:en "should be a keyword"}}
    :symbol {:error/message {:en "should be a symbol"}}

diff --git a/test/malli/error_test.cljc b/test/malli/error_test.cljc
@@ -373,28 +373,29 @@
              (me/humanize)))))
 
 (deftest double-test
-  (is (= {:a ["should be a double"]
-          :b ["should be at least 1"]
-          :c ["should be at most 4"]
-          :d [["should be at least 1"]
-              ["should be at most 4"]]
-          :e ["should be a double"]
-          :f ["should be 4"]}
-         (-> [:map
-              [:a :double]
-              [:b [:double {:min 1}]]
-              [:c [:double {:max 4}]]
-              [:d [:vector [:double {:min 1, :max 4}]]]
-              [:e [:double {:min 1, :max 4}]]
-              [:f [:double {:min 4, :max 4}]]]
-             (m/explain
-              {:a "123"
-               :b 0.0
-               :c 5.0
-               :d [0.0 5.0]
-               :e "123"
-               :f 5.0})
-             (me/humanize)))))
+  (doseq [t [:double :float]]
+    (is (= {:a [(str "should be a " (name t))]
+            :b ["should be at least 1"]
+            :c ["should be at most 4"]
+            :d [["should be at least 1"]
+                ["should be at most 4"]]
+            :e [(str "should be a " (name t))]
+            :f ["should be 4"]}
+           (-> [:map
+                [:a t]
+                [:b [t {:min 1}]]
+                [:c [t {:max 4}]]
+                [:d [:vector [t {:min 1, :max 4}]]]
+                [:e [t {:min 1, :max 4}]]
+                [:f [t {:min 4, :max 4}]]]
+               (m/explain
+                 {:a "123"
+                  :b 0.0
+                  :c 5.0
+                  :d [0.0 5.0]
+                  :e "123"
+                  :f 5.0})
+               (me/humanize))))))
 
 (deftest any-test
   (testing "success"