Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk #2064

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maxwhitemet
Copy link

Addresses #802

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.39%. Comparing base (84a8944) to head (e595640).
Report is 49 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2064    +/-   ##
========================================
  Coverage   98.39%   98.39%            
========================================
  Files         124      133     +9     
  Lines       12212    13124   +912     
========================================
+ Hits        12016    12914   +898     
- Misses        196      210    +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxwhitemet maxwhitemet reopened this Dec 10, 2024
@maxwhitemet maxwhitemet changed the title added the lightning_flash_accumulation_in_vicinity cell method missing from added the lightning_flash_accumulation_in_vicinity cell method missing from imengluk Dec 10, 2024
@maxwhitemet maxwhitemet marked this pull request as ready for review December 10, 2024 17:29
Copy link
Contributor

@lambert-p lambert-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed your code, it is looking good and I can't see any changes that need to be made. I will put it into second review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants