Improver api changes #2031
Merged
Improver api changes #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpelley
requested review from
MoseleyS,
gavinevans,
mo-robert-purvis,
brhooper and
SamGriffithsMO
SamGriffithsMO
approved these changes
Sep 17, 2024
mspelman07
approved these changes
Sep 20, 2024
| cube.rename(self._new_name) | ||
| if self._new_units: | ||
| cube.convert_units(self._new_units) | ||
| if self._coords_to_remove: |
There was a problem hiding this comment.
Just curious why you added the underscores to start of these. i.e. why not update it as self.new_name?
There was a problem hiding this comment.
Good software design - all data should be hidden within its class so that users don't accidentally (or purposely) change data owned by the class (hidden in the Python sense by convention, not truly 'hidden').
If you are interested, a recommended reading:
"Object-Oriented Design Heuristics" by Arthur J. Riel
There was a problem hiding this comment.
Just to feed curiosity, if you wanted to expose this data to users, it would be exposed via setter and getter methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some left over changes to IMPROVER api to support eppgl_precip_type configuration for EPP.
improver.utilities.cube_manipulationmissing from api list (needed for EPP).StandardiseMetadataplugin so that arguments have been moved to the init to make in line with IMPROVER guidelines.Issues