Adds tests showing out-of-range data returning from scipy interpolate… #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and adds an np.clip to the affected plugin to overcome this
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2007 +/- ##
==========================================
+ Coverage 98.39% 98.42% +0.03%
==========================================
Files 124 128 +4
Lines 12212 12469 +257
==========================================
+ Hits 12016 12273 +257
Misses 196 196 ☔ View full report in Codecov by Sentry. |
mspelman07
approved these changes
Jun 18, 2024
bayliffe
approved these changes
Jun 19, 2024
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
metoppv#2007) * Adds tests showing out-of-range data returning from scipy interpolate and adds an np.clip to the affected plugin to overcome this * isort * black * Adjusts test to test for what we care about * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and adds an np.clip to the affected plugin to overcome this
This was discovered because the interpolation of the rain falling level can produce values fractionally lower (machine-precision) than the snow falling level if both are zero before the interpolation is done.
Description
Testing: