Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct generate_ororgraphic_smoothing_coefficients doc-string #1999

Merged
merged 1 commit into from
May 20, 2024

Conversation

brhooper
Copy link
Contributor

@brhooper brhooper commented May 17, 2024

As an IMPROVER scientist, I like it when equations in doc-strings accurately represent the actual calculations being carried out, rather than bamboozling me.

This (ancient surprisingly young) PR changed the generate_orographic_smoothing_coefficients method so that it no longer required a coefficient to be specified, but rather normalised the calculated smoothing coefficients between user specified min and max values. The plugin doc-strings were updated accordingly, but a vestigial reference to a coefficient in the CLI doc-string remains. This PR removes that reference.

@brhooper brhooper changed the title Correct docstring Correct generate_ororgraphic_smoothing_coefficients doc-string May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (84a8944) to head (3a3de5f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
+ Coverage   98.39%   98.41%   +0.01%     
==========================================
  Files         124      124              
  Lines       12212    12337     +125     
==========================================
+ Hits        12016    12141     +125     
  Misses        196      196              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bayliffe bayliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has a lot of attitude, which makes it stand out in a crowd. The author has requested a review from someone he has implicitly called "ancient" in his description, which seems quite bold 👴

@bayliffe bayliffe merged commit 20c6ee9 into metoppv:master May 20, 2024
10 checks passed
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants