apply_bias_correction fix: add handling for missing forecast cube
#1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1995 +/- ##
==========================================
+ Coverage 98.39% 98.41% +0.01%
==========================================
Files 124 124
Lines 12212 12337 +125
==========================================
+ Hits 12016 12141 +125
Misses 196 196 ☔ View full report in Codecov by Sentry. |
benowen-bom
changed the title
apply_bias_correction fix: add handling for missing forecast cubeapply_bias_correction fix: add handling for missing forecast cube
btrotta-bom
previously approved these changes
May 14, 2024
gavinevans
requested changes
May 15, 2024
There was a problem hiding this comment.
Thanks @benowen-bom 👍
I think that this essentially looks fine. I've suggested some minor typo corrections.
Thanks Gavin for the review and picking up those typos. All fixed. |
gavinevans
approved these changes
May 16, 2024
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…etoppv#1995) * Update the cli signature for bias-correction cli and add tests for missing files. * Add function to separate forecast and forecast-error (bias) cubes * Tidy up split_forecasts_and_bias_files function and update acceptance tests. * Add unit tests for split_forecasts_and_bias_files function. * Update the apply_bias_correction CLI to raise warning when no calibration is applied. * Add unit test to check comment on output when no bias cubes supplied. * Fix typos picked up in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1994
This PR the function
split_forecasts_and_bias_filesto separate out the forecast cube from the forecast_error (bias) cubes based oncube.name(). Raises a Value Error when the forecast cube is not present, or when multiple forecast cubes have been passed in.The CLI now adds a warning when no bias_cubes are present and adds a comment to the attributes in the forecast (in line with how
apply_emos_coefficientshandles similar use case.Acceptance tests have been added to test this behaviour explicitly to ensure #1994 has been resolved. There is a new kgo that has been added for the case where no bias-cubes are added, included in the following PR: metoppv/improver_test_data#47.
Testing: