MOBT-430: Synthetic data utilities for creating spot-cubes #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to generate spot-data cubes for use in unit tests. Fixes up calls to the existing gridded synthetic data functions that did not use the keyword arguments explicitly. Adds unit tests for the new spot-data utilities. One unit test partially modified as an example.
bayliffe
commented
May 7, 2024
| @@ -443,7 +446,7 @@ def test_error_unmatched_realizations(self): | |||
| """Test error is raised if the realizations provided do not match the | |||
| data dimensions""" | |||
| realizations_len = 4 | |||
| data_len = len(self.data_3d[0]) | |||
| data_len = self.data_3d.shape[0] | |||
There was a problem hiding this comment.
Bug in original test.
bayliffe
commented
May 7, 2024
| @@ -456,7 +459,7 @@ def test_error_unmatched_height_levels(self): | |||
| """Test error is raised if the heights provided do not match the | |||
| data dimensions""" | |||
| height_levels_len = 4 | |||
| data_len = len(self.data_3d[0]) | |||
| data_len = self.data_3d.shape[0] | |||
There was a problem hiding this comment.
Bug in original test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1993 +/- ##
==========================================
+ Coverage 98.39% 98.40% +0.01%
==========================================
Files 124 124
Lines 12212 12322 +110
==========================================
+ Hits 12016 12126 +110
Misses 196 196 ☔ View full report in Codecov by Sentry. |
gavinevans
requested changes
May 10, 2024
There was a problem hiding this comment.
Thanks @bayliffe 👍
I think that this PR is largely fine. I've only added some very minor comments.
improver_tests/calibration/dz_rescaling/test_apply_dz_rescaling.py
Outdated
Show resolved
Hide resolved
gavinevans
requested changes
May 13, 2024
There was a problem hiding this comment.
Thanks @bayliffe 👍
This looks fine. I've suggested one minor docstring edit.
gavinevans
previously approved these changes
May 13, 2024
gavinevans
approved these changes
May 14, 2024
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
) * Synthetic spot data creation utilities added. Adds the ability to generate spot-data cubes for use in unit tests. Fixes up calls to the existing gridded synthetic data functions that did not use the keyword arguments explicitly. Adds unit tests for the new spot-data utilities. One unit test partially modified as an example. * Centralise the datetime format definition that corresponds to our typical format. * Some unit tests that use spot-cubes adapted as a demonstration. * Fix doc-string indentation issue for sphinx. * Review response. Improved doc-strings and use of global variables. * Typo correction. * Corrects typos highlighted in review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/metoppv/mo-blue-team/issues/430
The commits are broken up as follows:
Testing: