Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pinning to treelite rather than lightgbm. #1981

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

benowen-bom
Copy link
Contributor

@benowen-bom benowen-bom commented Feb 15, 2024

Currently the scheduled tests are failing:

improver_tests/calibration/rainforests_calibration/conftest.py:299: ModuleNotFoundError
=========================== short test summary info ============================
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test__check_num_features[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test__empty_config_warning[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test__evaluate_probabilities[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test__calculate_threshold_probabilities[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test__get_ensemble_distributions[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test_lead_time_without_matching_model[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test_process_ensemble_specifying_thresholds[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
ERROR improver_tests/calibration/rainforests_calibration/test_ApplyRainForestsCalibrationLightGBM.py::test_process_deterministic[treelite] - ModuleNotFoundError: No module named 'treelite_runtime'
= 5060 passed, 545 skipped, 1 xfailed, 5601 warnings, 8 errors in 196.43s (0:03:16) =
Error: Process completed with exit code 1.

The issue seems to be a change within treelite package. Fix to pin this package with #1966 pinned lightgbm rather than treelite. This PR is to unpin lightgbm and pin treelite.

Testing:

  • Ran tests and they passed OK

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb4b29d) 98.40% compared to head (08d2acf) 98.40%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1981   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         124      124           
  Lines       12125    12125           
=======================================
  Hits        11931    11931           
  Misses        194      194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@btrotta-bom btrotta-bom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@benowen-bom benowen-bom merged commit 87c6daa into metoppv:master Feb 15, 2024
10 checks passed
@benowen-bom
Copy link
Contributor Author

Thanks @btrotta-bom.

MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants