-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up weighted blending documentation #1961
Fix up weighted blending documentation #1961
Conversation
…d blenidng doc-string to new location.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1961 +/- ##
=======================================
Coverage 98.37% 98.38%
=======================================
Files 123 124 +1
Lines 11942 11976 +34
=======================================
+ Hits 11748 11782 +34
Misses 194 194
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A request.
improver/blending/weighted_blend.py
Outdated
@@ -269,8 +269,7 @@ class PercentileBlendingAggregator: | |||
|
|||
References: | |||
Combining Probabilities by Caroline Jones, 2017: | |||
https://github.com/metoppv/improver/files/1128018/ | |||
Combining_Probabilities.pdf | |||
/improver/doc/files/Combining_Probabilities.pdf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/improver/doc/files/Combining_Probabilities.pdf | |
:download:`Combining Probabilities by Caroline Jones, 2017 <../files/Combining_Probabilities.pdf>` |
Could we make this downloadable in the external documentation with a link like this please?
The :download:
bit makes readthedocs copy the file across to an accessible location. The path is relative to the source
directory in the improver directory strucuture (improver/doc/source
).
You cannot just commit this change as you need to delete the line above or it will have the title of the pdf twice.
You can see what that will look like here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this - I've made the suggested change.
* Add Combining_Probabilities.pdf to /doc/files. Update link in weighted blenidng doc-string to new location. * Change following review - change document path to a download link in docstring.
Addresses https://github.com/metoppv/mo-blue-team/issues/497
Description
Moves document which describes the weighted blending method into /improver/doc/files/ and updates the link to that document within the weighted blending doc-string to refer to the new location.
Testing: