MOBT-494: Phase probability plugin without percentile generation #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 98.33% 98.32% -0.01%
==========================================
Files 120 120
Lines 11383 11376 -7
==========================================
- Hits 11193 11186 -7
Misses 190 190
|
mspelman07
requested changes
May 19, 2023
improver/psychrometric_calculations/precip_phase_probability.py
Outdated
Show resolved
Hide resolved
improver/psychrometric_calculations/precip_phase_probability.py
Outdated
Show resolved
Hide resolved
improver/psychrometric_calculations/precip_phase_probability.py
Outdated
Show resolved
Hide resolved
mspelman07
requested changes
May 23, 2023
mspelman07
previously approved these changes
May 24, 2023
MoseleyS
requested changes
May 30, 2023
improver/psychrometric_calculations/precip_phase_probability.py
Outdated
Show resolved
Hide resolved
...ver_tests/psychrometric_calculations/precip_phase_probability/test_PrecipPhaseProbability.py
Show resolved
Hide resolved
|
@MoseleyS I've added some acceptance tests to demonstrate that the code works with lat-lon grids. |
… a rain or snow phase is chosen if somehow the falling level of the two is identical; this would otherwise end up as sleet, which is not awful either, but here we hedge by the slightest amount towards snow.
MoseleyS
approved these changes
Jun 5, 2023
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…oppv#1903) * Starting to rewrite tests. * Unit tests updated. * Tweaks to unit tests and new acceptance tests. * Further tests added. Comparator for snow changed to ge to ensure that a rain or snow phase is chosen if somehow the falling level of the two is identical; this would otherwise end up as sleet, which is not awful either, but here we hedge by the slightest amount towards snow. * Checksum update and style fixes. * Add extra test. * Add value error to doc-string. * Review changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #1902
The phase-probability CLI and plugin have been modified to remove the internal neighbourhooding. Instead the plugin now relies upon input data being provided with percentile data if that is desired, where these percentiles may have been constructed from a neighbourhood. This will allow us to use this plugin with spot data, where the percentiles have been generated on the grid prior to spot extraction; we can't neighbourhood spot-data sensibly.
The changes also allow us to extract probabilities without the use of neighbourhoods (and no resulting percentile coordinate), such that we can use non-equal-area grid data without having to apply neighbourhoods. This allows us to continue using the phase-probability plugin with global data (as was recently implemented: #1902).
Testing: