Implement expected value via integration over probability thresholds #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
==========================================
+ Coverage 98.17% 98.22% +0.04%
==========================================
Files 113 114 +1
Lines 10336 10678 +342
==========================================
+ Hits 10147 10488 +341
- Misses 189 190 +1
Continue to review full report at Codecov.
|
btrotta-bom
reviewed
Jun 8, 2022
Also add parameterized tests to pick up this issue
btrotta-bom
previously approved these changes
Jun 23, 2022
benowen-bom
reviewed
Jun 24, 2022
benowen-bom
previously approved these changes
Jun 29, 2022
There was a problem hiding this comment.
Thanks for responding to my comments. As I expected, the resolution was likely to be leave as is but I figured that it was worthwhile raising the questions.
I've left one suggestion for adding a comment on the +/- np.inf bounds, but I don't think is necessary given the issue you mentioned in the comment so I would be happy to leave it out (I'll leave this to your digression).
Either way, I'm happy with what is here. Great work!
benowen-bom
approved these changes
Jun 30, 2022
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Jul 1, 2022
* master: Calc temperature after latent heat release (metoppv#1739) Fixed broken links (metoppv#1745) Vicinity processing CLI (metoppv#1749) Rainforest minor fixes (metoppv#1751) Implement expected value via integration over probability thresholds (metoppv#1734) Exclude hidden directories and their sub-directories from the init check test. This accommodates IDEs that store information in hidden directories, i.e. vscode. (metoppv#1748) # Conflicts: # improver/psychrometric_calculations/psychrometric_calculations.py # improver_tests/acceptance/test_vicinity.py
2 tasks
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…etoppv#1734) * Implement expected value over thresholds * Add tests for non-monotonic data and thresholds lt/gt * Update acceptance test docstring * min/max of threshold spacing and ECC bounds * Fix interpolation mismatched with thresholds Also add parameterized tests to pick up this issue * Add unit test for unequally spaced thresholds * Fix black * Remove duplicated data equality check * Update comment explaining extra thresholds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up to #1719, implement processing of threshold data by numerical integration over probability thresholds, removing the quick-to-implement but poor performance implementation using ConvertProbabilitiesToPercentiles.
The acceptance test data is unchanged for this PR.
The time to run the acceptance test on threshold data reduced from ~1.5 seconds down to ~0.2 seconds on my workstation. There are significant performance improvements on larger data sets, such as whole-country sized grids.
Testing: