Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx 5.0 requires setting language #1728

Merged
merged 1 commit into from
May 30, 2022
Merged

Sphinx 5.0 requires setting language #1728

merged 1 commit into from
May 30, 2022

Conversation

tjtg
Copy link
Contributor

@tjtg tjtg commented May 30, 2022

Tests run against latest package versions failed due to newly released Sphinx 5.0.0 requiring the configuration file set language. The existing None value now results in a warning.

Testing:

  • Ran tests and they passed OK

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1728 (3704b2e) into master (57f76c0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1728   +/-   ##
=======================================
  Coverage   98.01%   98.01%           
=======================================
  Files         112      112           
  Lines       10310    10310           
=======================================
  Hits        10105    10105           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57f76c0...3704b2e. Read the comment docs.

Copy link
Contributor

@thbom001 thbom001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What can I say when four characters in total are changed. This looks good, except it would have been nicer to have language = "to" :-)

@tjtg tjtg merged commit 6213f36 into metoppv:master May 30, 2022
@tjtg tjtg deleted the sphinx5en branch June 24, 2022 03:05
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants