Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOBT-139: Merge WX modal bug fix PR into hotfix branch #1620

Merged
merged 3 commits into from
Nov 16, 2021

Conversation

bayliffe
Copy link
Contributor

Replaces #1616 which was raised against master.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

…ile.

This change also ensures that a mode cell method is added to give 
consistent metadata in the case of single file inputs.
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #1620 (99637e3) into Hotfix_branch_1.0.2 (f45d5e7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           Hotfix_branch_1.0.2    #1620   +/-   ##
====================================================
  Coverage                98.07%   98.07%           
====================================================
  Files                      110      110           
  Lines                    10007    10010    +3     
====================================================
+ Hits                      9814     9817    +3     
  Misses                     193      193           
Impacted Files Coverage Δ
improver/wxcode/modal_code.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45d5e7...99637e3. Read the comment docs.

@bayliffe bayliffe force-pushed the mobt139_into_hotfix branch from 7aba7fb to 99637e3 Compare November 16, 2021 10:56
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these modifications, @bayliffe 👍

@gavinevans gavinevans merged commit f9e085b into metoppv:Hotfix_branch_1.0.2 Nov 16, 2021
@bayliffe bayliffe deleted the mobt139_into_hotfix branch July 4, 2022 08:42
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
* Ensure than wxmodal produces only day codes even for a single input file.

This change also ensures that a mode cell method is added to give 
consistent metadata in the case of single file inputs.

* Review changes.

* Updated checksums
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants