Ensure consistent percentiles from EMOS if no coefficients provided #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## Hotfix_branch_1.0.2 #1615 +/- ##
====================================================
Coverage 98.07% 98.07%
====================================================
Files 110 110
Lines 10003 10003
====================================================
Hits 9810 9810
Misses 193 193 Continue to review full report at Codecov.
|
bayliffe
requested changes
Nov 15, 2021
| @@ -157,6 +157,31 @@ def process( | |||
| warnings.warn(msg) | |||
| return prob_template | |||
|
|
|||
| if percentiles: | |||
| percentiles = [np.float32(p) for p in percentiles] | |||
| constr = iris.Constraint(percentile=percentiles) | |||
There was a problem hiding this comment.
This probably needs to be a lambda function to handle float comparisons.
There was a problem hiding this comment.
For robustness, I've altered this to be use a lambda function for the float comparison.
bayliffe
approved these changes
Nov 15, 2021
…ded but a list of desired percentiles are provided.
…within the input forecast.
gavinevans
force-pushed
the
mobt108_consistent_percentiles
branch
from
a11b3fe to
0ee3863
Compare
MoseleyS
approved these changes
Nov 15, 2021
This was referenced Nov 15, 2021
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…etoppv#1615) * Add ability to subset the input forecast if no coefficients are provided but a list of desired percentiles are provided. * Modifications to raise an error if the percentiles requested are not within the input forecast. * Updates following review comments. * Update checksums by branching from 1.0.1 tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/metoppv/mo-blue-team/issues/108
Description
This PR ensures that if a list of desired percentiles are provided, then the forecast resulting from the apply-emos-coefficients CLI will have these desired percentiles whether or not the coefficients are provided.
Further information is available in this comment.
Testing: