Add CLI for ingesting tabular forecasts and observations into EMOS #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…passing in a list of percentiles, improvements to the unit tests to make them more reflective of the intended input files, checks to ensure the percentiles can be considered to be quantiles and other improvements.
…5.0." This reverts commit 5ccce69.
gavinevans
force-pushed
the
improver1538_tabular_ingestion_cli4
branch
from
5ddf334 to
a390238
Compare
3 tasks
|
@bayliffe and @fionaRust have reviewed a previous version of this PR gavinevans#16 |
fionaRust
previously approved these changes
Oct 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #1592 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 110 110
Lines 9917 9944 +27
=======================================
+ Hits 9724 9751 +27
Misses 193 193
Continue to review full report at Codecov.
|
… dependencies between the calibration and ECC code.
…rover1538_tabular_ingestion_cli4 * improver1538_move_tabular_ingestion_functions: Move dataframe to cube utilities to a separate file to avoid circular dependencies between the calibration and ECC code.
2 tasks
…lar_ingestion_cli4 * upstream/master: Move dataframe to cube utilities (metoppv#1593) Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
fionaRust
approved these changes
Oct 25, 2021
bayliffe
approved these changes
Oct 25, 2021
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Oct 25, 2021
…lar_ingestion_cli_fp_format * upstream/master: Add CLI for ingesting tabular forecasts and observations into EMOS (metoppv#1592) Support providing a static additional predictor when applying EMOS coefficients (metoppv#1591) Move dataframe to cube utilities (metoppv#1593) Added constant for ultraviolet_index_daytime_max. (metoppv#1590)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…etoppv#1592) * Add CLI and acceptance tests. * Modifications to the CLI and underlying functions to add support for passing in a list of percentiles, improvements to the unit tests to make them more reflective of the intended input files, checks to ensure the percentiles can be considered to be quantiles and other improvements. * Minor style updates. * Modifications to support the use of fastparquet at version 0.5.0. * Revert "Modifications to support the use of fastparquet at version 0.5.0." This reverts commit 5ccce69. * Clean-up. * Add test using an additional predictor. * Add additional acceptance tests for exceptions in the CLI. * Update docstrings and add support for returning None from a CLI. * Move dataframe to cube utilities to a separate file to avoid circular dependencies between the calibration and ECC code. * Correct import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #1538
Dependent upon #1572, #1582.
This is a duplicate of gavinevans#16 pointed at master. Note that this PR has been updated to include #1593.
Description
This PR builds upon work done in #1582 to add an
estimate_emos_coefficients_from_tableCLI that converts the pandas dataframe into an iris cube (#1582) and passes that iris cube to the existing EMOS functionality.Note that this PR does contain an update to acceptance.py to support providing a directory as a known good output in the acceptance tests. This is required for compatibility with a partitioned parquet file.
Please note that the decision about whether to use fastparquet 0.5.0 or 0.7.1 is subject to change due to issues with the Conda environments (https://github.com/MetOffice/improver_suite/pull/1026). The first three commits in this PR assumed the use of 0.7.1. This commit reverts the version of fastparquet to 0.5.0.
Further information is available in this comment.
Testing: