Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te-max data - We need this so we can generate data for days 6-8 when only 3h data are available.
Codecov Report
@@ Coverage Diff @@
## master #1568 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 107 107
Lines 9567 9567
=======================================
Hits 9372 9372
Misses 195 195
Continue to review full report at Codecov.
|
gavinevans
added
the
FY21/22 New Outputs
gavinevans
requested changes
Sep 27, 2021
| @@ -74,7 +74,8 @@ def _get_inputs(cubes: CubeList) -> Tuple[Cube, Cube]: | |||
| """ | |||
| Separates CAPE and precipitation rate cubes and checks that the following | |||
| match: forecast_reference_time, spatial coords, time-bound interval and | |||
| that CAPE time is exactly one hour older than precipitation rate time. | |||
| that CAPE time is at the lower bound of precipitation rate time. | |||
There was a problem hiding this comment.
As a note, and unrelated to this PR, the acceptance tests for the lightning_from_cape_and_precip.py CLI are currently failing due a mismatch in the units for the number_of_lightning_flashes_per_unit_area coordinate i.e. m-2 vs s-1.
There was a problem hiding this comment.
Fixed. Final tweak from #1550 hadn't been committed and merged - it has now.
- Improves tests and doc-strings
gavinevans
requested changes
Sep 27, 2021
| @@ -142,6 +143,7 @@ def test_3d_cubes(cape_cube, precip_cube, expected_cube): | |||
| assert np.allclose(result.data, expected_cube.data) | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Black is currently failing and it's probably because of this blank line.
gavinevans
approved these changes
Sep 27, 2021
bayliffe
approved these changes
Sep 28, 2021
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Oct 5, 2021
* bayliffe/mobt77: Review changes. Acceptance test added. Add type-hinting throughout. Formatting. Adding unit tests. Grouping solution and rename. First draft of a modal symbol plugin. Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568) Moves position of land-sea-mask in threshold CLI (metoppv#1565) Re-label a diagnostic as a period diagnostic (metoppv#1561) Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550) Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…te-max data (metoppv#1568) * Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data - We need this so we can generate data for days 6-8 when only 3h data are available. * First review - Improves tests and doc-strings * Black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1518
We need this so we can generate data for days 6-8 when only 3h data are available.
Testing: