Implement Resolves comment
#80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundibundi
reviewed
Jul 1, 2019
| @@ -116,7 +116,15 @@ const asyncLambda = async () => {}; | |||
|
|
|||
| // Async functions are supported | |||
| // Returns: <Promise> | |||
| const asyncFunc = async function() {}; | |||
| // Resolves: <Object> | |||
There was a problem hiding this comment.
I'd prefer to avoid adding keywords for such cases. I think it'll be better to allow to customize types:
// Returns: <Promise<{ a, b }>>
// a <number>
// b <string>This would also allow to specify Map, Set types etc. (i.e. Map<string, number>, Set<string>).
SemenchenkoVitaliy
force-pushed
the
impl-resolves-comment
branch
3 times, most recently
from
deee3da to
0322562
Compare
SemenchenkoVitaliy
force-pushed
the
impl-resolves-comment
branch
from
0322562 to
bce675b
Compare
Closes: #77
SemenchenkoVitaliy
force-pushed
the
impl-resolves-comment
branch
from
bce675b to
6e89aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #77.
Info: metarhia/filestorage#12 (comment).