Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add ironic secrets files and junit e2e result file to gitignore #2154

Merged
merged 1 commit into from
Dec 12, 2024
Merged

🌱 Add ironic secrets files and junit e2e result file to gitignore #2154

merged 1 commit into from
Dec 12, 2024

Conversation

mquhuy
Copy link
Member

@mquhuy mquhuy commented Dec 12, 2024

scripts/ci-e2e.sh nowadays generates secrets as files for ironic and bmo overlays used in E2E, and at the end of the test, xml files to store result of the tests. All of these files need to be git-ignored.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 12, 2024
@mquhuy
Copy link
Member Author

mquhuy commented Dec 12, 2024

/cc @kashifest @tuminoid @lentzi90 @Rozzii @Sunnatillo

tuminoid
tuminoid reviewed Dec 12, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@mquhuy mquhuy force-pushed the mquhuy/add-to-gitignore branch from 2652f00 to c505a02 Compare December 12, 2024 10:14
tuminoid
tuminoid reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2024
Sunnatillo
Sunnatillo approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/lgtm

@metal3-io-bot
Copy link
Contributor

@Sunnatillo: Overrode contexts on behalf of Sunnatillo: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2024
@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo, tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,tuminoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Rozzii
Rozzii reviewed Dec 12, 2024
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot merged commit ea8302b into metal3-io:main Dec 12, 2024
14 checks passed
@metal3-io-bot metal3-io-bot added this to the CAPM3 - v1.9 milestone Dec 12, 2024
@metal3-io-bot metal3-io-bot deleted the mquhuy/add-to-gitignore branch December 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@tuminoid tuminoid tuminoid left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

@kashifest kashifest Awaiting requested review from kashifest

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
CAPM3 - v1.9
Development

Successfully merging this pull request may close these issues.
5 participants
@mquhuy @metal3-io-bot @tuminoid @Rozzii @Sunnatillo