Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong ComicInfo.xml generation when date in metadata is incomplete #114

Closed
oae opened this issue Oct 25, 2022 · 1 comment · Fixed by #115
Closed

Wrong ComicInfo.xml generation when date in metadata is incomplete #114

oae opened this issue Oct 25, 2022 · 1 comment · Fixed by #115
Labels
bug Something isn't working

Comments

@oae
Copy link

oae commented Oct 25, 2022

Describe the bug

If the date field is incomplete in anilist (for example year and month exist but the day is null), mangal writes 0 as the value in ComicInfo.xml. This causes komga to fail.

image

Reproduction steps

You can see an example manga in this link

image

Expected behavior

It should not put an invalid value for dates.

Additional context

No response

Operating System

Linux
@oae oae added the bug Something isn't working label Oct 25, 2022
@metafates
Copy link
Owner

Hi! Thanks for noticing! Will fix

metafates added a commit that referenced this issue Oct 25, 2022
@metafates
fix: do not put an invalid value for dates in ComicInfo.xml #114
4d5e6ed
@metafates metafates mentioned this issue Oct 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v3.14.2 metafates/mangal
2 participants
@oae @metafates