-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update workflows and add deploy workflow #672
base: master
Are you sure you want to change the base?
Conversation
It looks like there's an issue with Codecov:
Could you add the Codecov token to the repository secrets as described here? Alternatively, we could consider removing this action and switching to something like Jest Coverage Report. |
The entire release process today is with release-it. See react-native-render-html/packages/render-html/.release-it.js Lines 1 to 22 in be73d81
It entails the following:
The version 6.4.0 was an accident; only the "publish to GitHub" part worked and I didn't find time to fix the currently broken release process. I appreciate this PR, but I think we need a proper plan for a new release process first. |
I'm well aware our CI is broken; I am planning on fixing it this weekend; or you may want to take a look. Already did this in https://github.com/native-html/core; just look at recent commits for inspiration (I will have to configure the codecov app for this to work though, but I need approval from a Meliorence org admin, CC @Exilz) |
@DorianMazur To circumvent broken Codecov integration, you may toggle this flag: react-native-render-html/.github/workflows/ci.yml Lines 40 to 43 in bfc98a9
|
Might want to update |
Checks
Description
This pull request updates the actions in the existing workflows and introduces a new
deploy
workflow. The new workflow will prepack and release the package to npm.@jsamr We need to add a new secret named
NPM_TOKEN
for this process.