-
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Applying temp workaround for CI in node 12 and 13
- Loading branch information
1 parent
6372e18
commit f7cc5a9
Showing
2 changed files
with
18 additions
and
1 deletion.
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
.github/workflows/avoid-double-delete-ref-in-object-wrap.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- /media/hdd/dev/node-addon-api-master/napi-inl.h 2020-01-21 06:41:58.000000000 +0100 | ||
+++ node_modules/node-addon-api/napi-inl.h 2020-01-26 16:33:38.000000000 +0100 | ||
@@ -3121,8 +3121,10 @@ | ||
Object object = Value(); | ||
// It is not valid to call `napi_remove_wrap()` with an empty `object`. | ||
// This happens e.g. during garbage collection. | ||
- if (!object.IsEmpty()) | ||
+ if (!object.IsEmpty()) { | ||
napi_remove_wrap(Env(), object, nullptr); | ||
+ this->SuppressDestruct(); | ||
+ } | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters