Canonical alias #174
Draft
Canonical alias #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnwbr
reviewed
Jun 20, 2022
| // as of now spaces need a canonical alias and be listed in the room direcotry in order to be joinable via federation | ||
| // we create the alias with the title of the item seperated by dashes and in lower case. | ||
| // @TODO sanitise for special characters which might be allowed in room name but not for the alias | ||
| const alias = '#' + space.name.replace(/\s+/g, '-').toLowerCase() + '-' + localStorage.getItem('mx_user_id').substring(1) |
There was a problem hiding this comment.
Should we also add a random 4-digit number or so in case someone adds two content items with the very same name?
| if (config.medienhaus.createCanonicalAliasOnPublish) { | ||
| // as of now spaces need a canonical alias and be listed in the room direcotry in order to be joinable via federation | ||
| // we create the alias with the title of the item seperated by dashes and in lower case. | ||
| // @TODO sanitise for special characters which might be allowed in room name but not for the alias |
There was a problem hiding this comment.
I think lodash's kebabCase() would help here:
fnwbr
reviewed
Jun 20, 2022
| if (config.medienhaus.createCanonicalAliasOnPublish) { | ||
| await matrixClient.setRoomDirectoryVisibility(roomId, 'private') | ||
| .catch(console.debug) | ||
| await matrixClient.deleteAlias('#' + space.rooms[0].name.replace(/\s+/g, '-').toLowerCase() + '-' + localStorage.getItem('mx_user_id').substring(1)) |
There was a problem hiding this comment.
-If- we ever decide to change the "algorithm" how we generate those aliases, the code wouldn't work for projects anymore, that were created with the "old syntax".
Instead maybe we can make use of the unstableGetLocalAliases function, and then just delete all aliases for the given room at once:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add canonical alias when publishing an item.
As of now it looks like this is needed to be able to join a space from a different server.