feat: implements convert mnemonic to privateKey #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My knowledge was short and I couldn't run the test again. |
0xHansLee
approved these changes
Aug 17, 2022
Co-authored-by: Youngjoon Lee <[email protected]>
docs/examples.md
Outdated
Comment on lines
151
to
154
| import {Secp256k1 as CryptoSecp256k1, stringToPath, sha256} from "@cosmjs/crypto"; | ||
| import {panacead} from "../testutils"; | ||
| import {TextEncoder} from "util"; | ||
| import {Secp256k1} from "./secp256k1"; |
There was a problem hiding this comment.
Suggested change
| import {Secp256k1 as CryptoSecp256k1, stringToPath, sha256} from "@cosmjs/crypto"; | |
| import {panacead} from "../testutils"; | |
| import {TextEncoder} from "util"; | |
| import {Secp256k1} from "./secp256k1"; | |
| import { Secp256k1 as CryptoSecp256k1, stringToPath } from "@cosmjs/crypto"; | |
| import { Secp256k1 } from "@medibloc/panacea-js"; |
Co-authored-by: Youngjoon Lee <[email protected]>
youngjoon-lee
approved these changes
Aug 18, 2022
|
I'm gonna improve our lint script and also make it run in CI. |
Yep. Very good. |
|
@youngjoon-lee |
yup. will do it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a function to convert to privateKey using
mnemonicandhdPath