Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

test: ipfs unit test #102

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

test: ipfs unit test #102

wants to merge 10 commits into from

Conversation

inchori
Copy link
Contributor

@inchori inchori commented Nov 10, 2022

Implement a IPFS test code with docker.

  • Add a test code for Add and Get method.

@inchori inchori added this to the Data Deal milestone Nov 10, 2022
@inchori inchori self-assigned this Nov 10, 2022
gyuguen
gyuguen reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very nice!
I left a few comment

ipfs/ipfs_test.go Show resolved Hide resolved
ipfs/suite/suite.go Outdated Show resolved Hide resolved
gyuguen
gyuguen approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee Awaiting requested review from youngjoon-lee

@audtlr24 audtlr24 Awaiting requested review from audtlr24

@0xHansLee 0xHansLee Awaiting requested review from 0xHansLee

At least 2 approving reviews are required to merge this pull request.

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
Data Deal
Development

Successfully merging this pull request may close these issues.
2 participants
@inchori @gyuguen