Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove cosmwasm #640

Merged
merged 13 commits into from
Feb 24, 2023
Merged

feat: remove cosmwasm #640

merged 13 commits into from
Feb 24, 2023

Conversation

audtlr24
Copy link
Contributor

Background

We decided it would be better to remove cosmwasm from the chain. There are three reasons for this

  1. Hardship in removing CosmWasm once somebody starts using it; currently, nobody is using CosmWasm on Panacea yet
  2. Possibility that anybody can deploy a contract that does not fit the purpose of Panacea
  3. Replacable through Cosmos SDK v0.46.x that now includes x/nft module later

@audtlr24 audtlr24 added the CosmWasm CosmWasm module related label Feb 20, 2023
@audtlr24 audtlr24 self-assigned this Feb 20, 2023
@audtlr24
Copy link
Contributor Author

I haven't tested the upgrade handler yet. I will open the pr after testing is complete.

@audtlr24
Copy link
Contributor Author

audtlr24 commented Feb 22, 2023 •
edited
Loading

Upgrading directly from v2.0.5 had issues with the VersionMap part, so I tested the upgrade in branch v2.0.5/add-set-version-map.

@audtlr24 audtlr24 marked this pull request as ready for review February 22, 2023 08:19
@gyuguen
Copy link
Contributor

gyuguen commented Feb 24, 2023

I think you can remove to wasm config in Dockerfile

https://github.com/medibloc/panacea-core/blob/main/Dockerfile

  • Line 8~9
  • Line 20~21
  • Line 28~29

@gyuguen
Copy link
Contributor

gyuguen commented Feb 24, 2023

And you can remove this part.
https://github.com/medibloc/panacea-core/blob/ft/na/remove-cosmwasm/.gitbook/overview/tech-stack.md?plain=1#L45
https://github.com/medibloc/panacea-core/blob/ft/na/remove-cosmwasm/README.md?plain=1#L15

gyuguen
gyuguen approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested this locally and didn't have any issues.
And I left a few comment :)

app/ante.go Show resolved Hide resolved
youngjoon-lee
youngjoon-lee reviewed Feb 24, 2023
View reviewed changes
.gitbook/overview/tech-stack.md Show resolved Hide resolved
app/app.go Outdated Show resolved Hide resolved
youngjoon-lee
youngjoon-lee approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,man

inchori
inchori approved these changes Feb 24, 2023
View reviewed changes
Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

0xHansLee
0xHansLee approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@audtlr24 audtlr24 merged commit 2e17318 into release/v2.0.x Feb 24, 2023
@audtlr24 audtlr24 deleted the ft/na/remove-cosmwasm branch February 24, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inchori inchori inchori approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@audtlr24 audtlr24

Labels
CosmWasm CosmWasm module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@audtlr24 @gyuguen @youngjoon-lee @0xHansLee @inchori