Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new option: halt-height #63

Merged
merged 2 commits into from
Oct 14, 2020
Merged

Add a new option: halt-height #63

merged 2 commits into from
Oct 14, 2020

Conversation

youngjoon-lee
Copy link
Contributor

@youngjoon-lee youngjoon-lee commented Oct 13, 2020 •
edited
Loading

Closes #60

This will be released as v1.2.6-internal.

Tests:

$ panacead start --halt-height 30

...
I[2020-10-13|18:00:14.889] Executed block                               module=state height=30 validTxs=0 invalidTxs=0
I[2020-10-13|18:00:14.893] halting node per configuration               module=main height=30

@youngjoon-lee youngjoon-lee requested a review from cl9200 October 13, 2020 09:03
youngjoon-lee
youngjoon-lee commented Oct 13, 2020
View reviewed changes
go.mod Outdated
@@ -28,4 +28,4 @@ require (
gopkg.in/yaml.v2 v2.2.7 // indirect
)

replace github.com/cosmos/cosmos-sdk => github.com/medibloc/cosmos-sdk v0.35.6-internal
replace github.com/cosmos/cosmos-sdk => github.com/medibloc/cosmos-sdk v0.35.6-internal.0.20201005064440-b291387e4dc7
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Use a proper tag after merging medibloc/cosmos-sdk#6

cl9200
cl9200 approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@cl9200 cl9200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@youngjoon-lee youngjoon-lee merged commit 78afd5e into v1.2 Oct 14, 2020
@youngjoon-lee youngjoon-lee deleted the ft/60/halt-height branch October 14, 2020 10:00
youngjoon-lee pushed a commit that referenced this pull request Dec 2, 2020
Add a new option: halt-height (#63)
f67780b 
Use the cosmos: v0.35.7
youngjoon-lee pushed a commit that referenced this pull request Dec 2, 2020
Add a new option: halt-height (#63)
e036f5f 
Use the cosmos: v0.35.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cl9200 cl9200 cl9200 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youngjoon-lee @cl9200