Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use stdout when encrypt and decrypt data #561

Merged
merged 8 commits into from
Dec 21, 2022
Merged

feat: use stdout when encrypt and decrypt data #561

merged 8 commits into from
Dec 21, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 19, 2022

Closes #554

@inchori inchori added this to the v2.1.0-beta milestone Dec 19, 2022
@inchori inchori self-assigned this Dec 19, 2022
@inchori
Copy link
Author

inchori commented Dec 19, 2022

I'll re-open this PR when decrypt-data test done.

@inchori inchori marked this pull request as draft December 19, 2022 07:38
youngjoon-lee
youngjoon-lee reviewed Dec 20, 2022
View reviewed changes
cmd/panacead/cmd/decrypt_data.go Outdated
}
decryptedDataBase64 := base64.StdEncoding.EncodeToString(decryptedData)

cmd.Println(decryptedDataBase64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should use fmt.Fprint(cmd.OutOrStdout(), ...).
The cmd.Println calls fmt.Fprintln(cmd.OutOrStderr(), ...) internally, which use stderr, not stdout.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0b0451c.

gyuguen
gyuguen approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I left a comment related to typo

cmd/panacead/cmd/decrypt_data.go Outdated Show resolved Hide resolved
@inchori inchori marked this pull request as ready for review December 21, 2022 06:49
youngjoon-lee
youngjoon-lee approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

0xHansLee
0xHansLee approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

audtlr24
audtlr24 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inchori inchori merged commit 8f5da44 into main Dec 21, 2022
@inchori inchori deleted the ft/554/use_stdout_en/decrypte_data branch December 21, 2022 07:52
@inchori inchori mentioned this pull request Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

use stdout instead of output-filepath for CLI encrypt/decrypt-data
5 participants
@inchori @youngjoon-lee @gyuguen @audtlr24 @0xHansLee