Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add CLI submit-consent #548

Merged
merged 9 commits into from
Dec 14, 2022
Merged

feat: Add CLI submit-consent #548

merged 9 commits into from
Dec 14, 2022

Conversation

inchori
Copy link

@inchori inchori commented Dec 13, 2022

  • Add a CLI for submit-consent.

@inchori inchori added this to the v2.1.0-beta milestone Dec 13, 2022
@inchori inchori self-assigned this Dec 13, 2022
0xHansLee
0xHansLee approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I also realized that this command is missed.

x/datadeal/client/cli/txSubmitConsent.go Outdated Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xHansLee 0xHansLee mentioned this pull request Dec 14, 2022
Merged
gyuguen
gyuguen approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@gyuguen gyuguen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

youngjoon-lee
youngjoon-lee approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@inchori inchori merged commit 36ac57d into main Dec 14, 2022
@inchori inchori deleted the ft/na/submit_consent_cli branch December 14, 2022 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@gyuguen gyuguen gyuguen approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@inchori inchori

Labels
None yet
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.
5 participants
@inchori @youngjoon-lee @gyuguen @audtlr24 @0xHansLee