Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add base64 encoding in data encryption #547

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

0xHansLee
Copy link
Contributor

encrypt-data CLI returns encrypted data encoded using base64, which can be used to request for data validation.

@0xHansLee 0xHansLee added this to the v2.1.0-beta milestone Dec 13, 2022
@0xHansLee 0xHansLee requested a review from cl9200 as a code owner December 13, 2022 05:25
@0xHansLee 0xHansLee self-assigned this Dec 13, 2022
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@inchori inchori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@0xHansLee 0xHansLee merged commit 8d1b9e0 into main Dec 13, 2022
@0xHansLee 0xHansLee deleted the fix/na/data-encryption-encoding branch December 13, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants