Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added verify uniqueID of certificate #542

Merged
merged 28 commits into from
Dec 12, 2022
Merged

feat: added verify uniqueID of certificate #542

merged 28 commits into from
Dec 12, 2022

Conversation

gyuguen
Copy link
Contributor

@gyuguen gyuguen commented Dec 8, 2022 •
edited
Loading

Implement

  • Added unique_id field in UnsignedCertificate
  • Added verify uniqueID of certificate
  • Added test msg validation of deal

inchori and others added 23 commits December 6, 2022 15:15
@inchori
feat: add skeleton code for datadeal module
34d058b
@inchori
fix
6b17689
@inchori
fix
351464b
@inchori
feat: add create a Deal and query a Deal keeper function
22b7b59
@inchori
rename
ff05626
@inchori
Merge branch 'ft/na/skeleton_code_datadeal' into ft/512/create_deal_k…
b1702dc 
…eeper
@inchori
fix
a5397f1
@inchori
Merge branch 'ft/na/skeleton_code_datadeal' into ft/512/create_deal_k…
6fea92d 
…eeper
@inchori
fix
2c2b906
@inchori
Merge branch 'main' into ft/512/create_deal_keeper
b0bdaa8
@inchori
rename
b075d85
@gyuguen
feat: implement submit consent
e2fad75
@gyuguen
fix
6306f89
@gyuguen
fix
d498a81
@gyuguen
fix
100d34d
@gyuguen
fix
26101ad
@gyuguen
Merge branch 'main' into ft/513/implement_submit_consent
ee93f66
@gyuguen
fix
f3be8e1
@gyuguen
fix
47d1350
@gyuguen
feat: apply oracle commission
97a018a
@gyuguen
fix
fec02e4
@gyuguen
feat: added verify uniqueID of certificate
7009804
@gyuguen
Merge branch 'ft/513/implement_submit_consent' into ft/513/apply_orac…
d1b14ce 
…le_commission
@gyuguen gyuguen added this to the v2.1.0-beta milestone Dec 8, 2022
@gyuguen gyuguen self-assigned this Dec 8, 2022
@gyuguen gyuguen linked an issue Dec 8, 2022 that may be closed by this pull request
Implement SubmitConsent tx #513
Closed
@gyuguen gyuguen marked this pull request as draft December 9, 2022 01:30
@gyuguen gyuguen marked this pull request as ready for review December 9, 2022 01:53
gyuguen
gyuguen commented Dec 9, 2022
View reviewed changes
x/datadeal/types/message_deal.go
@@ -82,46 +82,6 @@ func (m *MsgSubmitConsent) GetSigners() []sdk.AccAddress {
return []sdk.AccAddress{oracleAddress}
}

func (m *Certificate) ValidateBasic() error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it to x/datadeal/types/certificate.go

inchori
inchori approved these changes Dec 9, 2022
View reviewed changes
Copy link

@inchori inchori left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
I left a one question.

x/datadeal/types/message_deal_test.go Show resolved Hide resolved
audtlr24
audtlr24 approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@audtlr24 audtlr24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

0xHansLee
0xHansLee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@0xHansLee 0xHansLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

youngjoon-lee
youngjoon-lee approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@youngjoon-lee youngjoon-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alles gut

Base automatically changed from ft/513/apply_oracle_commission to main December 12, 2022 08:08
@gyuguen gyuguen merged commit 4d043b6 into main Dec 12, 2022
@gyuguen gyuguen deleted the ft/513/add_verify_unique_id_of_certificate branch December 12, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inchori inchori inchori approved these changes

@0xHansLee 0xHansLee 0xHansLee approved these changes

@audtlr24 audtlr24 audtlr24 approved these changes

@youngjoon-lee youngjoon-lee youngjoon-lee approved these changes

@cl9200 cl9200 Awaiting requested review from cl9200 cl9200 is a code owner

Assignees

@gyuguen gyuguen

Labels
x/datadeal
Projects
None yet
Milestone
v2.1.0-alpha.3
Development

Successfully merging this pull request may close these issues.

Implement SubmitConsent tx
5 participants
@gyuguen @youngjoon-lee @audtlr24 @0xHansLee @inchori